Magnetic　Fe3O4　and　NiCo2O4　nanoparticles　were　used　as　core　materials.　The　ZnS　shell　layer　is　synthesized　with　zinc　acetate　and　thiourea　as　precursors　by　a　solvothermal　process.　NiCo2O4@ZnS　and　Fe3O4@ZnS　core-shell　nanoparticles　were　used　as　hydrogen　production　photocatalysts,　which　can　be　recycled　by　magnetic　force　for　repeated　hydrogen　generation.　The　morphology,　crystalline　property,　magnetic　property,　photocatalytic　activity,　and　magnetic　separation　capability　of　the　core-shell　photocatalysts　were　studied.　Fe3O4@ZnS　core-shell　nanoparticles　exhibit　better　magnetic　separation　capability　than　the　NiCo2O4@ZnS　analog.　The　optimized　photocatalytic　hydrogen　production　rates　of　NiCo2O4@ZnS　and　Fe3O4@ZnS　core-shell　nanoparticles　reach　880　μmol　h-1　g-1　and　3900　μmol　h-1　g-　1,　respectively.　Both　photocatalysts　can　be　recycled　by　magnetic　force.　Recycled　photocatalysts　exhibit　good　hydrogen　generation　performance　after　being　recycled　for　three　times.　©　(2014)　by　the　Committee　of　WHEC2014.